Adapting header rule to check for license type #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please mention also in the pr description that you took advantage of this to change foxglove to lichtblick in in the tslint library |
|
Just added some comments, please take a look |
aneuwald-ctw
requested changes
Oct 16, 2024
…but currently having issues with conflicts between tests
… that already, kept the new test that checks when the license and only the license is wrong
ctw-joao-luis
deleted the
adapting-header-rule-to-check-for-license-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a check for the type of repo license the header has and an error in case its missing.
Every project should have the repository license type defined on the eslintrc.yml from now on so lint can grab it from there.
Also changed the foxglove interfaces to Lichtblick ones and had to fix some formatting errors highlighted by lint
Tests and lint passed successfully